-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: Customer import deletes exiting customer entity Fields #11968
Fix bug: Customer import deletes exiting customer entity Fields #11968
Conversation
$customerFieldsToUpdate = array_filter($this->customerFields, function ($field) use ($columnsToUpdate) { | ||
return in_array($field, $columnsToUpdate); | ||
}); | ||
return $customerFieldsToUpdate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change :
to ;
Please (Line 287)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups! I edited the commit. Thanks for noticing.
…re not present on Import file
5ebca71
to
d6c6e66
Compare
); | ||
} | ||
|
||
return $this; | ||
} | ||
|
||
private function getCustomerEntityFieldsToUpdate(array $entitiesToUpdate): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe a docblock to this method with a short explanation of the bug this method fixes. Is there actually a github issue for this fix cause you could add a link to that here.
…mport file. - magento#11968 - Importing a import file to update customer data, results in entity fields being removed if the columns are not present on the imported file.
Importing a import file to update customer data, results in
entity fields
being removed if the columns are not present on the imported file.That is the case for all fields defined here:
Importing a customer should result on adding or editing new data but it should keep previous information if the column is not present on imported file.
Contribution checklist