Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#11691: Wrong return type for getAttributeText($attributeCode) #12003

Merged
merged 1 commit into from
Nov 21, 2017
Merged

magento/magento2#11691: Wrong return type for getAttributeText($attributeCode) #12003

merged 1 commit into from
Nov 21, 2017

Conversation

p-bystritsky
Copy link
Contributor

Description

Magento\Catalog\Model\Product::getAttributeText return annotation changed to "string|array|null"

Fixed Issues (if relevant)

  1. Wrong return type for getAttributeText($attributeCode) #11691: Wrong return type for getAttributeText($attributeCode)

Manual testing scenarios

  1. Open [Magento root]/app/code/Magento/Catalog/Model/Product.php code.
  2. Find getAttributeText method.
  3. It's return annotation should be "@return string|array|null"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@osrecio osrecio self-assigned this Nov 16, 2017
@osrecio osrecio added this to the November 2017 milestone Nov 16, 2017
@osrecio
Copy link
Member

osrecio commented Nov 16, 2017 •
edited
Loading

Thanks for your contribution @p-bystritsky ! Can you please squash your commits? If you don't know how to make it, I can help you.

@osrecio osrecio requested review from osrecio and removed request for osrecio November 16, 2017 21:18
@osrecio osrecio self-requested a review November 20, 2017 11:41
@okorshenko okorshenko self-assigned this Nov 20, 2017
@okorshenko okorshenko merged commit bd9054a into magento:2.2-develop Nov 21, 2017
okorshenko pushed a commit that referenced this pull request Nov 21, 2017
MAGETWO-84018: #11691: Wrong return type for getAttributeText($attrib…
5341e43 
…uteCode) #12003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osrecio osrecio osrecio approved these changes

Assignees

@osrecio osrecio

@okorshenko okorshenko

Labels
Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@p-bystritsky @osrecio @magento-team @okorshenko @magento-engcom-team