Magento 2.2.0 Solution for Cross-sell product placeholder image size … #12018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkublytskyi
suggested changes
Nov 4, 2017
| <image id="cart_cross_sell_products" type="thumbnail"> | ||
| <width>200</width> | ||
| <height>248</height> | ||
| <image id="cart_cross_sell_products" type="small_image"> |
There was a problem hiding this comment.
These changes make sense. As Luma theme is developed mostly for demo but not for extending I would ask you to make similar changes for Blank theme that developed to be a parent for custom themes.
…issue. Add Solution for Blank theme.
|
Hello @vkublytskyi I have made similar changes for the Blank theme. Please review it from your end and let me know if we need any other changes on this. |
mayankzalavadia
approved these changes
Nov 6, 2017
mayankzalavadia
approved these changes
Nov 6, 2017
vkublytskyi
approved these changes
Nov 6, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 7, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 7, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83279: Magento 2.2.0 Solution for Cross-sell product placeholder image size … #12018 - MAGETWO-83270: 11700: "Something Went Wrong" error for limited access admin user #11993 - MAGETWO-83085: fix #8846: avoid duplicated attribute option values #11785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Magento 2.2.0 Solution for Cross-sell product placeholder image size …
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist