Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11946: Layer navigation showing wrong product count #12063

Merged
merged 3 commits into from
Dec 13, 2017
Merged

11946: Layer navigation showing wrong product count #12063

merged 3 commits into from
Dec 13, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 6, 2017

Description

Added check if need to show out of stock products.

Fixed Issues (if relevant)

  1. Layer navigation showing wrong product count  #11946: Layer navigation showing wrong product count

Manual testing scenarios

  1. Create simple product and attach it to category.
  2. Find simple product on frontend catalog(Layer navigation is showing all visibility product count).
  3. Enable "Display Out of Stock Products" (Stores->Configuration->Catalog->Inventory)
  4. Set a simple product "out of stock"
  5. Go to category with that product
  6. Layer navigation should show the same product count as in step 2.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko self-assigned this Nov 22, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 22, 2017
@sidolov sidolov self-assigned this Dec 13, 2017
@magento-team magento-team merged commit e195dd6 into magento:2.2-develop Dec 13, 2017
magento-team pushed a commit that referenced this pull request Dec 13, 2017
@ishakhsuvarov
MAGETWO-84370: 11946: Layer navigation showing wrong product count #1…
b0ce3b6 
…2063
magento-team pushed a commit that referenced this pull request Dec 13, 2017
@ishakhsuvarov
Merge pull request #1848 from magento-engcom/2.2-develop-prs
3839c0f 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-85583: #12378: Regions list in Directory module for India #1007
 - MAGETWO-85580: Fixes #12660 invalid parameter configuration provided for argument #12661
 - MAGETWO-85534: #8647: [GitHub] Order of how arguments are merged in multiple di.xml-… #995
 - MAGETWO-84370: 11946: Layer navigation showing wrong product count #12063
Fixed issues:
 - #12378 Regions list in Directory module for India
 - #12452 ACL permissions issue
 - #12660 Invalid parameter configuration provided for $block argument upon no ACL permissions to the block
 - #8647 Order of how arguments are merged in multiple di.xml-files causes unexpected results
 - #11946 Layer navigation showing wrong product count
@sidolov
Copy link
Contributor

sidolov commented Dec 14, 2017

Hi @RomaKis , consider to port this solution for 2.3 branch
Thank you for your contribution!

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 14, 2017
@ghost ghost mentioned this pull request Jan 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

@sidolov sidolov

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@RomaKis @sidolov @magento-team @okorshenko @magento-engcom-team