Update Cm_Cache_Backend_Redis to v1.8 and Credis_Client to v1.5 #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add chunking to use_lua mode as well. Minor optimization without lua mode (do not array_unique if not needed) ~ colinmollenhour - Added chunking logic to the SUNION call to avoid lengthy blocking ~ davidalger - Proper handling of getFillingPercentage() when maxmemory in Redis is set ~ brusch - Fix for Lua script when removing a huge amount of keys in _removeByMatchingAnyTags() ~ frozenminds - Misc improvments Update Credis_Client to v1.5
|
Hi, can it be removed from Magento code base at all and just loaded via Composer or there are some issues with this? |
|
That would be the best option. |
|
@orlangur I think this would be an issue currently due to how the library exists today in it's home repository (location of source files and dependency on hackathon magento-composer project), but long-term I agree…maybe I'm wrong though and it's sitting right there under my nose! |
This was referenced Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Cm_Cache_Backend_Redis to v1.8
Update Credis_Client to v1.5