Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --no-update option to sampledata:deploy and sampledata:remove commands #12359

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Add a --no-update option to sampledata:deploy and sampledata:remove commands #12359

merged 1 commit into from
Dec 4, 2017

Conversation

schmengler
Copy link
Contributor

@schmengler schmengler commented Nov 20, 2017

Description

This PR adds a --no-update flag for sampledata commands. It will be passed to composer, so that the user can add and remove sampledata modules without automatic composer update. This way, the actual update can be postponed to a manual composer execution. It gives the developer more control and is especially useful in scenarios where running composer from within bin/magento results in permission issues.

Manual testing scenarios

First scenario:

  1. Run bin/magento sampledata:deploy --no-update on an installation without sampledata
  2. composer.json should have been updated, nothing installed

Second scenario:

  1. Run bin/magento sampledate:remove --no-update on an installation with sampledata
  2. composer.json should have been updated, nothing installed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio self-assigned this Nov 20, 2017
@osrecio
Copy link
Member

osrecio commented Nov 20, 2017

Thanks for your contribution @schmengler , can you please check the failing tests? Specifically this, also, can you squash your commits ?
Thanks!

Unit test has been refactored to be reused for new cases
@schmengler
Copy link
Contributor Author

@osrecio Done! Ironically, the codacy issues that we see now ("long variables") come from code that I did not change, only moved up to a new abstract class. Hope, that's okay :)

@osrecio
Copy link
Member

osrecio commented Nov 20, 2017

Yes, Codacy get changes from your commit although you only move it.
No problem about it :)

@osrecio
Copy link
Member

osrecio commented Dec 3, 2017

Hi @schmengler , I tested and all is ok for me, thanks for your improvement.
Can you make the Backport for 2.3. Will be appreciate it. (ping me in the comment, I will assign to me, will be more quickly to process)

@okorshenko okorshenko merged commit 6eef1d0 into magento:2.2-develop Dec 4, 2017
okorshenko pushed a commit that referenced this pull request Dec 4, 2017
@osrecio
Copy link
Member

osrecio commented Dec 5, 2017

@schmengler Thanks for your contribution, In the next release we will have this flag to use with command sampledata:deploy and sampledata:remove

@schmengler
Copy link
Contributor Author

@osrecio sorry for the delay, here's a port to 2.3-develop: #12663

@osrecio
Copy link
Member

osrecio commented Dec 13, 2017

Thanks @schmengler ! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants