Issue/12342/js test driver removal #12406

KarlDeux · 2017-11-22T16:05:42Z

Refactoring and creation of Jasmine Unit testing.
Removed JSTestDriver.

Description

Currently Magento is using 2 different sets of tools for the JavaScript Testing:

JSTestDriver, which is considered legacy and is not supported anymore by the core team.
Jasmine, which was introduced to replace JSTestDriver. All new JS tests are implemented using it and executed in multiple CI environments, including public Travis CI and Magento's in-house CICD infrastructure.
To remove legacy framework it is required to reimplement remaining tests using Jasmine, and completely remove JSTestDriver support afterwards.

Fixed Issues (if relevant)

JSTestDriver removal #12342 : JSTestDriver removal

Manual testing scenarios

Make sure that NPM is installed, if not $ npm install.
Generate static view files in Magento that are going to be tested $ php bin/magento setup:static-content:deploy -f.
Run Jasmine testing $ grunt spec:.

All the tests should pass.

List of JS which require attention:

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

Removed transtale-test.js from jsTestDriver suite.

KarlDeux · 2017-11-22T16:10:10Z

@ishakhsuvarov @magento-engcom-team are we still using lib/web/mage/translate-inline.js
JsTestDriver/testsuite/mage/translate_inline/translate-inline-test.js ?

Couldn't find any usage into the magento 2 and those tests are hard to deal with since that'd involve DOM inclusions. Without jasmine-jquery it'd be hard.

Removed accordion.js and index.html for jsTestDriver test.

omiroshnichenko · 2017-11-22T17:25:26Z

Hi, @KarlDeux. Thank you for your interest in this task. We still using translate-inline in admin and front areas. For such case, you can create separate html file and fetch it using require text plugin.

KarlDeux · 2017-11-22T17:27:18Z

Ok @omiroshnichenko will do so.

omiroshnichenko · 2017-11-22T17:47:40Z

@KarlDeux Im have already rewritten decorate-test.js. Is it be ok if I will make commit to your branch?

KarlDeux · 2017-11-22T17:48:58Z

@omiroshnichenko sure thing! I'm fixing now accordion and finishing collapsible.

Removed transtale-test.js from jsTestDriver suite.

Removed accordion.js and index.html for jsTestDriver test.

(cherry picked from commit b3fedbc)

…al' into issue/12342/JSTestDriver-removal # Conflicts: # dev/tests/js/jasmine/tests/lib/mage/accordion.test.js

KarlDeux · 2017-11-22T18:44:16Z

@omiroshnichenko looks like decorate test are failing:

   Error: Method customMethod does not exist on jQuery.decorate in http://localhost:8000/pub/static/frontend/Magento/blank/en_US/jquery.js (line 253) (1)

omiroshnichenko · 2017-11-22T19:03:06Z

@KarlDeux My fault. Fixed.

Fixed enable method. It was not enabling and activating the collapsible. This was detected on Jasmine unit testing. Minor repositioning to this.options.disabled on disable method for consistency purposes with enable method.

…endly.

KarlDeux · 2017-11-23T17:53:04Z

Had to apply some changes to lib/web/mage/collapsible.js in order to be testable.
Also discovered that enable function wasn't working properly running the tests. Did some changes so it is actually enabling the chollapsible item (enabling tab-index, showing the element), dunno if this is the actual behavior that should be applied but reading the previous test cases it'd make sense.

- Added translate-inline.test.js and removed JsTestDriver equivalent.

- Added calendar.test.js and removed JsTestDriver equivalent.

- Fix translate-inline.test.js, save original ajax

- Fix loader.test.js and removed JsTestDriver equivalent.

- Added suggest.test.js and removed JsTestDriver equivalent. - Added tree-suggest.test.js and removed JsTestDriver equivalent.

- Added tabs.test.js and removed JsTestDriver equivalent.

omiroshnichenko · 2017-12-21T18:03:55Z

@KarlDeux Maybe I can help you with validation test?

…12342/JSTestDriver-removal

omiroshnichenko · 2018-01-04T07:30:05Z

@KarlDeux If you busy, I can start work on validation-test?

KarlDeux · 2018-01-17T16:58:59Z

@omiroshnichenko hey! I was out for vacations, just commited the file as I have it (still needs work). Feel free to finish it :)

omiroshnichenko · 2018-01-17T17:02:52Z

@KarlDeux Ohhh!!! I just finished all test and ready to commit. Maybe I will make force push if you do not mind?

KarlDeux · 2018-01-17T17:06:27Z

Sure @omiroshnichenko ! go for it!

- Added validation.test.js and removed JsTestDriver equivalent. - Fix unstable tests.

…12342/JSTestDriver-removal

- Fix timeout dropdown close.

- Fix jstree override.

…12342/JSTestDriver-removal

- Fix validation.

magento-engcom-team · 2018-01-19T16:19:04Z

@KarlDeux thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

KarlDeux · 2018-01-19T19:17:16Z

@omiroshnichenko guess we're done right? Shall I squash it all or do you want to do so?

ishakhsuvarov · 2018-01-20T12:39:01Z

@KarlDeux Going to merge it as is, don't see any problem in keeping history for this amount of work done 👍
Thank you!

Carlos Lizaga added 2 commits November 21, 2017 17:36

Added translate.test.js for Jasmine compatibility unit testing.

2abaf8c

Removed transtale-test.js from jsTestDriver suite.

Fix translate.test to be eslint friendly

1691621

magento-engcom-team added the improvement label Nov 22, 2017

okorshenko assigned omiroshnichenko Nov 22, 2017

Carlos Lizaga added 2 commits November 22, 2017 17:50

Added accordion.test.js for Jasmine testing.

ea56695

Removed accordion.js and index.html for jsTestDriver test.

Eslint upgrades.

126a1e3

omiroshnichenko and others added 9 commits November 22, 2017 19:53

Added decorate.test.js for Jasmine testing. Removed decorate-test.js

b3fedbc

Added translate.test.js for Jasmine compatibility unit testing.

0117f86

Removed transtale-test.js from jsTestDriver suite.

Fix translate.test to be eslint friendly

3a907c2

Added accordion.test.js for Jasmine testing.

821bdaa

Removed accordion.js and index.html for jsTestDriver test.

Eslint upgrades.

2846c78

Eslint improvements and logical fixes for unit testing.

f4712cd

Added decorate.test.js for Jasmine testing. Removed decorate-test.js

f0a1877

(cherry picked from commit b3fedbc)

Merge remote-tracking branch 'karldeux/issue/12342/JSTestDriver-remov…

5e785eb

…al' into issue/12342/JSTestDriver-removal # Conflicts: # dev/tests/js/jasmine/tests/lib/mage/accordion.test.js

Eslint improvements and logical fixes for unit testing.

64bf208

Fix decorate.test.js

8595da6

Carlos Lizaga added 3 commits November 23, 2017 17:19

that - this consistency and splat complete function to be Jasmine fri…

9b28fe2

…endly.

Added collapsible.test.js and removed JsTestDriver equivalent.

4127a8c

KarlDeux closed this Nov 23, 2017

KarlDeux reopened this Nov 23, 2017

jscs:disable jsDoc

6366f83

omiroshnichenko added 6 commits December 20, 2017 16:49

#12342: JSTestDriver removal

36cfa45

- Added translate-inline.test.js and removed JsTestDriver equivalent.

#12342: JSTestDriver removal

b1b001a

- Added calendar.test.js and removed JsTestDriver equivalent.

#12342: JSTestDriver removal

b716482

- Fix translate-inline.test.js, save original ajax

#12342: JSTestDriver removal

c5a1722

- Fix loader.test.js and removed JsTestDriver equivalent.

#12342: JSTestDriver removal

40e6981

- Added suggest.test.js and removed JsTestDriver equivalent. - Added tree-suggest.test.js and removed JsTestDriver equivalent.

#12342: JSTestDriver removal

2fff734

- Added tabs.test.js and removed JsTestDriver equivalent.

Merge branch '2.2-develop' of github.com:magento/magento2 into issue/…

e510801

…12342/JSTestDriver-removal

omiroshnichenko added 3 commits January 18, 2018 12:10

#12342: JSTestDriver removal

a667b63

- Added validation.test.js and removed JsTestDriver equivalent. - Fix unstable tests.

Merge branch '2.2-develop' of github.com:magento/magento2 into issue/…

574daf5

…12342/JSTestDriver-removal

#12342: JSTestDriver removal

faed0c5

- Fix timeout dropdown close.

omiroshnichenko added this to the January 2018 milestone Jan 18, 2018

omiroshnichenko added the Release Line: 2.2 label Jan 18, 2018

#12342: JSTestDriver removal

ac8aa21

- Fix jstree override.

magento-team added the Progress: accept label Jan 19, 2018

KarlDeux closed this Jan 19, 2018

KarlDeux reopened this Jan 19, 2018

omiroshnichenko added 2 commits January 19, 2018 18:15

Merge branch '2.2-develop' of github.com:magento/magento2 into issue/…

fa69aa5

…12342/JSTestDriver-removal

#12342: JSTestDriver removal

64f9c6d

- Fix validation.

ishakhsuvarov mentioned this pull request Jan 20, 2018

JSTestDriver removal #12342

Closed

13 tasks

magento-team merged commit 64f9c6d into magento:2.2-develop Jan 20, 2018

magento-team pushed a commit that referenced this pull request Jan 20, 2018

MAGETWO-86859: Issue/12342/js test driver removal #12406

b641bf8

vkublytskyi added the port-to-2.3 label Jan 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue/12342/js test driver removal #12406

Issue/12342/js test driver removal #12406

KarlDeux commented Nov 22, 2017 •

edited by omiroshnichenko

Loading

KarlDeux commented Nov 22, 2017 •

edited

Loading

omiroshnichenko commented Nov 22, 2017

KarlDeux commented Nov 22, 2017

omiroshnichenko commented Nov 22, 2017

KarlDeux commented Nov 22, 2017 •

edited

Loading

KarlDeux commented Nov 22, 2017

omiroshnichenko commented Nov 22, 2017

KarlDeux commented Nov 23, 2017

omiroshnichenko commented Dec 21, 2017

omiroshnichenko commented Jan 4, 2018

KarlDeux commented Jan 17, 2018

omiroshnichenko commented Jan 17, 2018

KarlDeux commented Jan 17, 2018

magento-engcom-team commented Jan 19, 2018

KarlDeux commented Jan 19, 2018

ishakhsuvarov commented Jan 20, 2018

Issue/12342/js test driver removal #12406

Issue/12342/js test driver removal #12406

Conversation

KarlDeux commented Nov 22, 2017 • edited by omiroshnichenko Loading

Description

Fixed Issues (if relevant)

Manual testing scenarios

List of JS which require attention:

Contribution checklist

KarlDeux commented Nov 22, 2017 • edited Loading

omiroshnichenko commented Nov 22, 2017

KarlDeux commented Nov 22, 2017

omiroshnichenko commented Nov 22, 2017

KarlDeux commented Nov 22, 2017 • edited Loading

KarlDeux commented Nov 22, 2017

omiroshnichenko commented Nov 22, 2017

KarlDeux commented Nov 23, 2017

omiroshnichenko commented Dec 21, 2017

omiroshnichenko commented Jan 4, 2018

KarlDeux commented Jan 17, 2018

omiroshnichenko commented Jan 17, 2018

KarlDeux commented Jan 17, 2018

magento-engcom-team commented Jan 19, 2018

KarlDeux commented Jan 19, 2018

ishakhsuvarov commented Jan 20, 2018

KarlDeux commented Nov 22, 2017 •

edited by omiroshnichenko

Loading

KarlDeux commented Nov 22, 2017 •

edited

Loading

KarlDeux commented Nov 22, 2017 •

edited

Loading