Skip to content

[Backport 2.1-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

[Backport 2.1-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12579

merged 1 commit into from
Dec 11, 2017

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Dec 7, 2017

Description

Backport of #10504 / #12541.

Manual testing scenarios

  1. Run Magento on non-standard port (8082).
  2. Try to execute API methods using swagger UI.
  3. Base url without port is used.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll
Copy link
Member Author

Jeroenll commented Dec 7, 2017

@ishakhsuvarov Can you process this since you also did the port to 2.2-develop?

@ishakhsuvarov ishakhsuvarov self-assigned this Dec 7, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 7, 2017
@ishakhsuvarov
Copy link
Contributor

@JeroenVanLeusden I'm on it
Thank you

@magento-team magento-team merged commit bfbd9be into magento:2.1-develop Dec 11, 2017
magento-team pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
MAGETWO-85180: [Backport 2.1-develop] Fix swagger-ui on instances of …
f6f3516 
…Magento running on a non-standard port #12579
magento-team pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
Merge pull request #1817 from magento-engcom/2.1-develop-prs
95eaf87 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-85180: [Backport 2.1-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12579
 - MAGETWO-85097: [Backport-2.1] Added namespace to product videos fotorama events #12558
 - MAGETWO-83478: Add command to view mview state and queue #12050
@Jeroenll Jeroenll deleted the patch-3 branch December 27, 2017 08:47
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ishakhsuvarov ishakhsuvarov

Labels

Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.1

Projects

None yet

Milestone

December 2017

Development

Successfully merging this pull request may close these issues.

5 participants

@Jeroenll @ishakhsuvarov @magento-team @paales @aredridel