Ranged selects always miss the last range

[AntonEvers]

I found this bug because some of my categories were empty. catalog_category_product_index did not contain all category product relations that are in catalog_category_product. Per category type (anchor, non-anchor) the highest category id's were missing from the index.

Description

Ranged selects always miss the last range:

// 2.1-develop:
        $this->isValid = ($this->batchSize + $this->currentOffset) < $this->totalItemCount;

// 2.2-develop:
        $this->isValid = ($this->batchSize + $this->currentOffset) <= $this->totalItemCount;

Suppose you have a total item count of 530 items:
Batch size: 500
Offset: 0
(batch size + offset) = 500
500 <= 530 is TRUE, so generate a query with offset 0 and limit 500
Returns item 1 - 500

Batch size: 500
Offset: 500
(batch size + offset) = 1000
1000 <= 530 is FALSE, so DO NOT generate a query with offset 500 and limit 500
Query is not created
Does not return items 501 - 530

The actual check should be:

        $this->isValid = $this->currentOffset < $this->totalItemCount;

Suppose you have a total item count of 530 items:
Batch size: 500
Offset: 0
0 <= 530 is TRUE, so generate a query with offset 0 and limit 500
Returns item 1 - 500

Batch size: 500
Offset: 500
500 <= 530 is TRUE, so generate a query with offset 500 and limit 500
Returns item 500 - 530

Batch size: 500
Offset: 1000
1000 <= 530 is FALSE, so DO NOT generate a query with offset 1000 and limit 500
Query is not created

Fixed Issues (if relevant)

Manual testing scenarios

1. catalog_category_product_index should contain all category product relations that are also in catalog_category_product.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[osrecio]

Hi @ajpevers ,
thanks for your pull request! Please can you have a look at the failing unit test?

[AntonEvers]

@osrecio fixed it.

[osrecio]

Thanks @ajpevers . I will make some tests, because I see a before commit from core team and I will check why was introduced.

Meantime, can you squash your commits to have only one?. If you don't know how, feel free to contact with me and I will help you.

[AntonEvers]

@osrecio done, sorry for the delay.

[osrecio]

No problem, until this week I could'nt work for process PR. 👍 Thanks!