Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @escapeNotVerified from documentation #12639

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Remove @escapeNotVerified from documentation #12639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions dev/tests/static/testsuite/Magento/Test/Php/XssPhtmlTemplateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,14 @@ public function testXssSensitiveOutput()
* Static test will cover the following cases:
*
* 1. /\* @noEscape \*\/ before output. Output doesn't require escaping. Test is green.
* 2. /\* @escapeNotVerified \*\/ before output. Output escaping is not checked and
* should be verified. Test is green.
* 3. Methods which contains "html" in their names (e.g. echo $object->{suffix}Html{postfix}() ).
* 2. Methods which contains "html" in their names (e.g. echo $object->{suffix}Html{postfix}() ).
* Data is ready for the HTML output. Test is green.
* 4. AbstractBlock methods escapeHtml, escapeUrl, escapeQuote, escapeXssInUrl are allowed. Test is green.
* 5. Type casting and php function count() are allowed
* 3. AbstractBlock methods escapeHtml, escapeUrl, escapeQuote, escapeXssInUrl are allowed. Test is green.
* 4. Type casting and php function count() are allowed
* (e.g. echo (int)$var, echo (float)$var, echo (bool)$var, echo count($var)). Test is green.
* 6. Output in single quotes (e.g. echo 'some text'). Test is green.
* 7. Output in double quotes without variables (e.g. echo "some text"). Test is green.
* 8. Other of p.1-7. Output is not escaped. Test is red.
* 5. Output in single quotes (e.g. echo 'some text'). Test is green.
* 6. Output in double quotes without variables (e.g. echo "some text"). Test is green.
* 7. Other of p.1-6. Output is not escaped. Test is red.
*
* @param string $file
*/
Expand Down