Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12900: Braintree "Place Order" button is disabled after failed validation #12902

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Fix #12900: Braintree "Place Order" button is disabled after failed validation #12902

merged 1 commit into from
Jan 3, 2018

Conversation

joni-jones
Copy link
Contributor

Description

After failed payment form validation the "Place Order" button is still disabled because hosted-fields triggers an error on validation and isPlaceOrderActionAllowed is still returns false.

  • Added handler to enable "Place Order" button on failed validation
  • Covered changes by js unit test

Fixed Issues

  1. Braintree "Place Order" button is disabled after failed validation #12900: Braintree "Place Order" button is disabled after failed validation

Manual testing scenarios

  1. Add product to cart and proceed to checkout
  2. Fill all customer data and select shipping method. Proceed to payment
  3. Select Braintree credit card payment method
  4. Input credit card number (dummy)
  5. Omit expiry date or CVV
  6. Click "Place order" button
  7. Error "Payment Credit Card (Braintree) can't be initialized" briefly appears
  8. Input expiry date or CVV
  9. "Place order" button is disabled/not responsive

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@joni-jones
G#12900: Braintree "Place Order" button is disabled after failed vali…
0c5cb6a 
…dation

 - Added handler to enable "Place Order" button on failed validation
 - Covered changes by js unit test
@joni-jones joni-jones changed the title G#12900: Braintree "Place Order" button is disabled after failed validation Fix #12900: Braintree "Place Order" button is disabled after failed validation Dec 28, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Dec 28, 2017
@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 28, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 28, 2017
@magento-team magento-team mentioned this pull request Jan 3, 2018
Closed
@magento-team magento-team merged commit 0c5cb6a into magento:2.2-develop Jan 3, 2018
magento-team pushed a commit that referenced this pull request Jan 3, 2018
@ishakhsuvarov
MAGETWO-86112: Fix #12900: Braintree "Place Order" button is disabled…
6d7ee26 
… after failed validation #12902
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 3, 2018
@joni-jones joni-jones deleted the G#12900 branch July 2, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@joni-jones @magento-team @ishakhsuvarov @magento-engcom-team