Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wishlist item getBuyRequest with no options #12930

Conversation

jameshalsall
Copy link

@jameshalsall jameshalsall commented Dec 29, 2017

Description

Fixes an issue where the default value for a wishlist item's buyRequest data was null, when it must always be an array.

Fixed Issues (if relevant)

None that I know of.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@fooman fooman self-assigned this Dec 30, 2017
@fooman fooman added this to the December 2017 milestone Dec 30, 2017
@okorshenko okorshenko modified the milestones: December 2017, January 2018 Jan 8, 2018
@magento-team magento-team merged commit 79256fd into magento:2.1-develop Jan 8, 2018
@jameshalsall jameshalsall deleted the fix-wishlist-get-buy-request-with-no-options branch January 8, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants