[Backport to 2.3-develop] Changed constructor typo in Javascript class #12976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder: cherry-pick 33c476e also |
|
@orlangur That's exactly what I did, cherry pick 33c476e since that commit had changes in it which where not present in the 2.3-develop branch. This resulted in a merge conflict which I have resolved, keeping the changes in the 2.3-develop branch and adding the other typo which was fixed in that commit. |
orlangur
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11933
Original PR:
Changed variable with typo consturctor to constructor
This was already solved in the 2.3 develop branch, but another commit with a typo was also in the given PR. This was not yet present in de 2.3 develop branch, so backported the original PR to the 2.3 develop branch.