Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "top destinations" config field configurable on store level #13052

Merged

Conversation

avstudnitz
Copy link
Contributor

@avstudnitz avstudnitz commented Jan 8, 2018

Description

This makes the configuration field "Top destinations" configurable on store level. It was only available on global level before.

Fixed Issues

You may want to set different Top destination countries depending on website or store view. You could not do that up to now.

Manual testing scenarios

  1. Go to Stores -> Configuration -> General
  2. Switch the scope to any store view
  3. Check if you can see the configuration field "Top destinations" in the group "Country Options"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@avoelkl avoelkl self-assigned this Jan 8, 2018
@avoelkl
Copy link
Contributor

avoelkl commented Jan 8, 2018

Hi @avstudnitz,
Thanks for the PR, good idea to change the scope. I'll start the further processing of the PR :)

@avoelkl avoelkl added this to the January 2018 milestone Jan 8, 2018
@magento-team magento-team merged commit e05f92c into magento:2.2-develop Jan 8, 2018
coderimus pushed a commit to coderimus/magento2 that referenced this pull request Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants