Fixed a bug where type attribute for tag button was missing #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OnTapKristjan, thank you for the valuable contribution. This issue is confirmed internally and we will be ready to accept your PR when we fix issues with Travis build. |
|
Internal ticket: MAGETWO-38299 |
vpelipenko
added a commit
that referenced
this pull request
Jun 24, 2015
Fixed a bug where type attribute for tag button was missing
cpartica
pushed a commit
that referenced
this pull request
Jul 14, 2017
Fixed issues: - MAGETWO-69964 PHPCS cannot parse correctly syntax of PHP 7.x return types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug breaks extended grid in certain cases because without type="button" the behaviour of a 'button' will fall back to default type which is 'submit', if this happens the ancestor 'form' will automatically submit creating unexpected problems.