[FIX]: Recent orders are not filtered per store at the customer account page

[coderimus]

Description

Hello,

In this PR I provide fix for filtering recent orders block where previously orders were not filtered by store. You can have different accounts with the same emails for stores belong to a website and when you logged-in to one of those stores you will see 5 recent orders but it is possible to see orders from all stores belong to a website.

Main changes:

1. Magento\Sales\Block\Order\Recent

• Move recent orders select to separate method
• Filter selected collection by current store

2. Magento\Sales\Test\Unit\Block\Order\RecentTest

• Change test according to the class method changes

3. app/code/Magento/Sales/view/frontend/templates/order/recent.phtml

• Change sizeof() to count() and execute it only once instead of double call

Best regards,
Alex

Fixed Issues (if relevant)

N/A

Manual testing scenarios

1. Create 2 stores on one website
2. Create 2 accounts with the same email for previously added stores
3. Place orders per store
4. Log In to previously created account for which you created orders and check Recent Orders section. It will show orders for all stores

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[avoelkl]

Hi @coderimus, did you have a look to retrieve the current store id other than via adding a new dependency with StoreManager?

[avoelkl]

If we need this new dependency it needs to be backwards compatible, see here: http://devdocs.magento.com/guides/v2.0/contributor-guide/backward-compatible-development/#adding-a-constructor-parameter

[coderimus]

@avoelkl thank you so much for your response and review!
I think I can do this without including new dependency using $this->_storeManager property in the Block class and leave the unit test with the Mock object of the storeManagerInterface. As I can see they are the same objects.
I will implement this change, test it and deploy to review ASAP.
Thank you,
Alex

[avoelkl]

Hi @coderimus, thanks for your reply. Let me know if you need some help!

[avoelkl]

Hi @coderimus,
Thanks for the PR! Please have a look at my comment/review above. Thanks!

[coderimus]

Hi @avoelkl,
I provided requested changes. Please review them when it will be suitable for you :)

Changes explanation
I decided to implement backward compatibility and adding a new dependency to the class construct just to avoid overhead with Unit tests and do not refactor this block class too much which is also can generate more issues than benefits for this major version of Magento2.

The main reason why I added dependency and didn't use parent class property is that during block class instance initialization (while tests are running) the _construct() method is called and, unfortunately, it doesn't have _storeManager property from the parent class. In this case, I think it will be good just to save block class as it is. This block can be widely used and if we will remove/replace setOrders() Magento integrators can face problems with templates or other places where they call $block->getOrders()

[coderimus]

Hi @avoelkl sorry if I interrupt you but when you will have free time, please, review uploaded changes. :) Thank you!

[avoelkl]

Hi @coderimus!
Thanks for the update! I continue with processing the PR :)

[avoelkl]

Btw I saw there is a failing check from Codacy/PR Quality Review. We can ignore it in this case.

[coderimus]

Hi @avoelkl,
Sorry if interrupt you but just want to ask you about next: can I prepare the backport of this issue for 2.3 and 2.4 branches?
Have a good day,
Alex