Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] In checkout->multishipping-> new addres clean region when select country without dropdown for states #13364

Merged

Conversation

enriquei4
Copy link
Contributor

Description

In checkout->multishipping-> new addres clean region when select country without dropdown for states.

Before, when you select a country without dropdown for region, the region_id wasn't clean.

Fixed Issues

  1. M2.1 Multishipping Checkout step New Address - Old State is saved when country is changed #8621: M2.1 Multishipping Checkout step New Address - Old State is saved when country is changed

Manual testing scenarios

  1. Add multiple product to cart (minimum 2 product or 1 product with quantity 2) .
  2. Check Out with Multiple Addresses.
  3. Now Click on Enter a New Address button.
  4. Now fill the form with Country : United States and select State : New Jersey
  5. Others fields value can be anything you like
  6. Now before saving the form, do change in country and State.
  7. Select Country : Australia and set State: NSW
  8. No Click on Save Address Button.
  9. You will be redirected to Ship to Multiple Addresses page.
  10. In address dropdown, look for Address you just saved. You will see "New Jersey" in address dropdown.
  11. But we saved "NSW" as State from Multishipping New Address form.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@enriquei4 enriquei4 changed the title [Backport 2.2] Clean region when select country [Backport 2.2] In checkout->multishipping-> new addres clean region when select country without dropdown for states Jan 25, 2018
@miguelbalparda miguelbalparda self-assigned this Jan 25, 2018
@miguelbalparda miguelbalparda added this to the January 2018 milestone Jan 26, 2018
@magento-engcom-team magento-engcom-team merged commit 1b2a17c into magento:2.2-develop Jan 31, 2018
magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2018
… clean region when select country without dropdown for states #13364
@enriquei4 enriquei4 deleted the FIX-REGION-NEW-ADDRESS_2_2 branch May 3, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants