Issue 11175: fix i18n:collect-phrases so it also collects "translate args" #13470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidolov
requested changes
May 21, 2018
| * <translate args="'Items in Cart'"/> | ||
| */ | ||
| const HTML_FILTER = "/i18n:\s?'(?<value>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)'/i"; | ||
| const HTML_FILTER = "/i18n:\s?'(?<value_i18n>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)|translate args=\"'(?<value_translate_args>[^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)'\"/i"; |
Contributor
There was a problem hiding this comment.
It would be better deprecate this constant and add the new array with regular expressions for different cases with translation match. This approach will make the translations collecting process more clear.
Contributor
|
@PascalBrouwers , I am closing this PR now due to inactivity. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue #11175
fix i18n:collect-phrases so it also collects
<translate args="'Items in Cart'"/>Fixed Issues (if relevant)
Manual testing scenarios
php bin/magento i18n:collect-phrases app/code/Magento/Checkout | grep "Items in Cart"Or when magento is in the vendor folder:
php bin/magento i18n:collect-phrases vendor/magento/module-checkout | grep "Item in Cart""Items in Cart","Items in Cart"Contribution checklist