[Forwardport] Fix adding values to system variable collection #13735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13596
Changed select fields in joined variable value table in
Magento\Variable\Model\ResourceModel\Variable\Collection#addValuesToResult()
method to match DB schemaDescription
Method mentioned above tried to select field
value
from joinedvariable_value
table (which doesn't exist). I've replaced incorrect field with two proper ones:plain_value
andhtml_value
.Fixed Issues
Calling
Magento\Variable\Model\ResourceModel\Variable\Collection#addValuesToResult()
method results withZend_Db_Statement_Exception
thrown. Exception message:Manual testing scenarios
As the method is not used anywhere in the magento core there is no way to reproduce error with just clicking.
Contribution checklist