Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5463 - Use specified hashing algo in \Magento\Framework\Encryption\Encryptor::getHash #13885

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

k4emic
Copy link

@k4emic k4emic commented Feb 28, 2018

Original PR: #13884

Description

\Magento\Framework\Encryption\Encryptor::getHash would previously ignore the specified hashing algorithm version that was supplied

Fixed Issues (if relevant)

  1. The ability to store passwords using different hashing algorithms is limited #5463: The ability to store passwords using different hashing algorithms is limited

Manual testing scenarios

N/A, Magento currently has no support for specifying hashing algorithms by default.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-943 has been created to process this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants