Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Act better on existing input focus instead of removing it #14180

Merged
merged 1 commit into from
Mar 20, 2018
Merged

[Forwardport] Act better on existing input focus instead of removing it #14180

merged 1 commit into from
Mar 20, 2018

Conversation

namlier
Copy link
Contributor

@namlier namlier commented Mar 19, 2018

Original Pull Request

#13989
The focus of the input field is maintained, proper classes are added and autocomplete fires once the component is initialized. Fixes #13988.

Description

As already mentioned in issue referenced above this change proposes better approach when the user is already focused on the search input by detecting it and triggering appropriate methods.

Fixed Issues (if relevant)

  1. Mini search field looses focus after its JavaScript is initialized #13988 Mini search field looses focus after its JavaScript is initialized

Manual testing scenarios

  1. Load Magento 2 shop.
  2. Focus on mini search form field.
  3. Check that input no longer loses focus once its JavaScript is initialized.
  4. Check that proper active classes are applied when the user is focused on the search field and JavaScript gets initialized.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

The focus of the input field is maintained, proper classes are added and autocomplete fires once the component is initialized.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 19, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@mastiuhin-olexandr thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini search field looses focus after its JavaScript is initialized
5 participants