Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix product attribute ordering when more than 10 attributes #14183

Conversation

rostyslav-hymon
Copy link
Contributor

@rostyslav-hymon rostyslav-hymon commented Mar 19, 2018

Original Pull Request
#14083
When a product has more than 10 attributes, when viewing the product page, the order of the attributes becomes incorrect due to sorting alphabetically rather than numerically. (ie. 0,1,10,11,12,13,2,3,4,5,6,7,8,9)

Magento version 2.x

Trivial bugfix to force the javascript to interpret the position as a number.

@magento-engcom-team
Copy link
Contributor

@rostyslav-hymon thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit c1a9fab into magento:2.3-develop Mar 20, 2018
@ctadlock
Copy link

Where in the UI is this referring to? On the "Additional Info" tab on the product page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants