Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves adminhtml product grid issue #13338 #14336

Conversation

julian-van-drielen
Copy link

Added possibility to set store_id for ProductDataProvider in a data argument. This is also now set to zero (default store view) for the catalog/product/index product grid

Description

By adding a store_id field to the data array, it is now possible to pass a store_id to the ProductDataProvider, this resolves an issue causing the default data values in the product grid in the adminhtml to be invalid and not the default store.

Fixed Issues (if relevant)

  1. Products grid in admin does not display default values? #13338: Products grid in admin does not display default values?

Manual testing scenarios

  1. If needed, reproduce issue
  2. Apply PR as patch
  3. Clear cache, open product grid again
  4. Issue resolved

Contribution checklist

  • [✓] Pull request has a meaningful description of its purpose
  • [✓] All commits are accompanied by meaningful commit messages
  • [✓] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Julian van Drielen added 2 commits March 24, 2018 16:11
…gument. This is also now set to zero (default store view) for the catalog/product/index product grid
@mzeis mzeis added the Event: distributed-cd Distributed Contribution Day label Mar 24, 2018
@osrecio osrecio self-assigned this Mar 24, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 17, 2018
@sidolov
Copy link
Contributor

sidolov commented Apr 26, 2018

Hi @cream-julian , please, take a look at failed tests, looks like node 'argument' is not expected in ui component configuration xml.

@sidolov
Copy link
Contributor

sidolov commented May 10, 2018

@cream-julian , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration!

@sidolov sidolov closed this May 10, 2018
@julian-van-drielen
Copy link
Author

Continuing to work on this.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 2, 2018

CLA assistant check
All committers have signed the CLA.

@julian-van-drielen
Copy link
Author

@sidolov Please check this PR.

@osrecio
Copy link
Member

osrecio commented Jul 12, 2018

Hi @cream-julian,
Thanks for your contribution.

I think you should use $storeManager to get current store id from store manager in Magento/Catalog/Ui/DataProvider/Product/ProductDataProvider.php.

In this case you should revert changes added inMagento/Catalog/view/adminhtml/ui_component/product_listing.xml

@sidolov
Copy link
Contributor

sidolov commented Jul 27, 2018

@cream-julian , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants