Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove json helper data usage in AdminNotification #14438

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Remove json helper data usage in AdminNotification #14438

merged 2 commits into from
Apr 5, 2018

Conversation

dmanners
Copy link
Contributor

Description

The class Magento\Framework\Json\Helper\Data is deprecated. In this PR I remove the usage of this class in the module Magento\AdminNotification

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Json #9236: Upgrade ZF components. Zend_Json

Manual testing scenarios

  1. Setup some admin notifications and check that they are still working as desired,

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

dmanners added 2 commits March 29, 2018 09:49
@dmanners
magento#9236: remove the usage of the json data helper
cdca73b 
 - replace the json data help in the AdminNotification Messages block
@dmanners
magento#9236: remove the usage of the Json Data Helper
6561541 
 - replace the json data helper usage in the admin controller with the results factory
 - create a result of type json,
 - set the data array on the result type
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 29, 2018
@sidolov sidolov mentioned this pull request Apr 5, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 6561541 into magento:2.3-develop Apr 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 5, 2018
ENGCOM-1173: Remove json helper data usage in AdminNotification #14438
a58525c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@dmanners @sidolov @magento-engcom-team