Improve code structure in relation to else / if statements. #14576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Release Line: 2.3
Partner: Comwrap
partners-contribution
orlangur
requested changes
Apr 8, 2018
| @@ -98,10 +98,9 @@ protected function _getLatestItem() | |||
| { | |||
| if ($this->_latestItem == null) { | |||
| $items = array_values($this->_criticalCollection->getItems()); | |||
| $this->_latestItem = false; | |||
| if (count($items)) { | |||
| $this->_latestItem = $items[0]; | |||
There was a problem hiding this comment.
Ternary operator would fit better here.
| } | ||
| return $this->_groupRepository->getById($groupId)->getCode(); |
There was a problem hiding this comment.
Ternary operator would fit better here.
| } else { | ||
| $this->subscriptionHandler->processDisabled(); | ||
| } | ||
| $enabled ? $this->subscriptionHandler->processEnabled() : $this->subscriptionHandler->processDisabled(); |
There was a problem hiding this comment.
Ternary operator is NOT really suitable here as it decreases code readability. it is better to be used in assignments only.
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 10, 2018
|
Hi @nuzil. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves code structure for usage of if / else statements
Fixed Issues (if relevant)
No, code improvements
Manual testing scenarios
No, code improvements
Contribution checklist