Skip to content

[2.3] Optimize ID to SKU lookup of tier prices #14700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
May 25, 2018
Merged

[2.3] Optimize ID to SKU lookup of tier prices #14700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions app/code/Magento/Catalog/Model/Product/Price/TierPriceStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,10 @@ private function getExistingPrices(array $skus, $groupBySku = false)
$rawPrices = $this->tierPricePersistence->get($ids);
$prices = [];

$linkField = $this->tierPricePersistence->getEntityLinkField();
$skuByIdLookup = $this->buildSkuByIdLookup($skus);
foreach ($rawPrices as $rawPrice) {
$sku = $this->retrieveSkuById($rawPrice[$this->tierPricePersistence->getEntityLinkField()], $skus);
$sku = $skuByIdLookup[$rawPrice[$linkField]];
$price = $this->tierPriceFactory->create($rawPrice, $sku);
if ($groupBySku) {
$prices[$sku][] = $price;
Expand Down Expand Up @@ -300,21 +302,21 @@ private function isCorrectPriceValue(array $existingPrice, array $price)
}

/**
* Retrieve SKU by product ID.
* Generate lookup to retrieve SKU by product ID.
*
* @param int $id
* @param array $skus
* @return string|null
* @return array
*/
private function retrieveSkuById($id, $skus)
private function buildSkuByIdLookup($skus)
{
$lookup = [];
foreach ($this->productIdLocator->retrieveProductIdsBySkus($skus) as $sku => $ids) {
if (isset($ids[$id])) {
return $sku;
foreach (array_keys($ids) as $id) {
$lookup[$id] = $sku;
}
}

return null;
return $lookup;
}

/**
Expand Down