Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move customer.account.dashboard.info.extra block to contact information #14923

Merged
merged 1 commit into from
May 3, 2018
Merged

Move customer.account.dashboard.info.extra block to contact information #14923

merged 1 commit into from
May 3, 2018

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented May 1, 2018 •
edited by mzeis
Loading

Description

Move extension block to contact information. Seems not logic to add this to the newsletter section.

Fixed Issues (if relevant)

  1. None.

Manual testing scenarios

  1. Add custom block in reference customer_account_dashboard_info with name customer.account.dashboard.info.extra to display additional data in customers dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Ports

@JeroenVanLeusden JeroenVanLeusden added Release Line: 2.2 Partner: Reach Digital Pull Request is created by partner Reach Digital partner-contribution partners-contribution Pull Request is created by Magento Partner and removed partner-contribution labels May 1, 2018
@rogyar rogyar self-assigned this May 2, 2018
@rogyar
Copy link
Contributor

rogyar commented May 2, 2018

Good catch!

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 2, 2018
@JeroenVanLeusden JeroenVanLeusden mentioned this pull request May 3, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team merged commit 02ef628 into magento:2.2-develop May 3, 2018
magento-engcom-team pushed a commit that referenced this pull request May 3, 2018
@VladimirZaets
ENGCOM-1432: Move customer.account.dashboard.info.extra block to cont…
4b3ea1b 
…act information #14923
@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@JeroenVanLeusden JeroenVanLeusden deleted the JeroenVanLeusden-patch-3 branch May 4, 2018 07:02
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
@sergiy-v sergiy-v mentioned this pull request May 9, 2018
Merged
@mzeis
Copy link
Contributor

mzeis commented May 10, 2018

Note: has already been fixed in #14957, no forwardport needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rogyar rogyar

Labels
Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@JeroenVanLeusden @rogyar @magento-engcom-team @mzeis @paales