-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format the javascript code #14967
Format the javascript code #14967
Conversation
Hi @yogeshks , thank you for collaboration. Use javascript inside *.phtml file it's legacy code that we try to refactor according to Magento way. For that we have <script type="text/x-magento-init" /> tag, where we declare path to JS file and pass paramets if they are needed. Please make refactoring according to Magento way. |
Hi @VladimirZaets |
Hi @yogeshks , yes, you should create new JS file/component with the callback function, as example and use |
Hi @VladimirZaets |
Hi @yogeshks. Updates look good, thanks. I took your PR into processing. |
Hi @yogeshks. Thank you for your contribution. |
Description
Format the javascript code in the template file.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist