Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix $considerUseDefaultsAttribute assignment statement #15003

Closed

Conversation

likemusic
Copy link
Contributor

@likemusic likemusic commented May 4, 2018

Description

Seems that there is invalid assignment statement. I'm not sure.

Fixed Issues (if relevant)

  1. Unable to unselect all multiselect values #7687: Unable to unselect all multiselect values (possible, not sure)

Manual testing scenarios

Maybe by related issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi @likemusic, please fix the unit test app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilterTest.php that was failed with your fix.

I will try to reproduce issue #7687 with and without your fix.

@VladimirZaets
Copy link
Contributor

I can't reproduce the linked issue on the current Magento 2.2-develop branch.
So, I close this PR since it doesn't fix any issue & it merge potentially can introduce new bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants