Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set message-success in setup if we already have the latest version #15012

Merged
merged 2 commits into from May 8, 2018
Merged

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 5, 2018

Description

Currently the upgrade check in the setup uses message-error even if we already have the latest version.

how it currently is:
magento daniel-ruf de_setup_ 1

how it should be:
magento daniel-ruf de_setup_ 2

Logic wise it should be message-success in this case instead of message-error as this is not an error and is not what we expect from the UX perspective.

Manual testing scenarios

  1. update Magento 2 to the latest version
    2.open the upgrade check in the setup

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 5, 2018

CLA assistant check
All committers have signed the CLA.

@VladimirZaets
Copy link
Contributor

Hi, @DanielRuf , I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

@DanielRuf thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@DanielRuf
Copy link
Contributor Author

Hi @VladimirZaets, is there some required commit message style (as I see some PRs with [BUGFIX]) or similar (commitlint / commitizen could be probably helpful + husky or some prepush Git hooks for contributors)?

@VladimirZaets
Copy link
Contributor

@DanielRuf Currently, we haven't special required commit message style. Commits only must be accompanied by meaningful commit messages.
You can read all Magento contributing requirements here.
Thanks

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@DanielRuf DanielRuf deleted the fix/setup-message-success-latest-version branch May 8, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants