Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: checkout last 5 commits #15016

Merged
merged 1 commit into from May 8, 2018
Merged

chore: checkout last 5 commits #15016

merged 1 commit into from May 8, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

By default Travis checks out the last 50 commits. This PR is meant to see the performance gain by checking out the last 5 commits.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@DanielRuf
Copy link
Contributor Author

Some test timeout: https://travis-ci.org/magento/magento2/jobs/375364647

Should I push a new empty commit to trigger a new build or can someone retry the failing build?

We also need more and faster builds.

@VladimirZaets
Copy link
Contributor

Hi @DanielRuf , I restarted the build.

@DanielRuf
Copy link
Contributor Author

Hi @DanielRuf , I restarted the build.

Thanks.

@VladimirZaets
Copy link
Contributor

@DanielRuf but I have one question, why 5? rather than 1 as an example?

@DanielRuf
Copy link
Contributor Author

@DanielRuf but I have one question, why 5? rather than 1 as an example?

https://docs.travis-ci.com/user/customizing-the-build#Git-Clone-Depth

Please note that if you use a depth of 1 and have a queue of jobs, Travis CI won’t build commits that are in the queue when you push a new commit.

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@DanielRuf DanielRuf deleted the chore/checkout-last-5-commits branch May 8, 2018 18:29
mzeis added a commit that referenced this pull request May 10, 2018
This is a forward port of PR #15016. Check it for details on why exactly 5 etc.
mzeis added a commit to mzeis/magento2 that referenced this pull request May 10, 2018
This is a forward port of PR magento#15016. Check it for details on why exactly commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants