Loosened Regex on GB postcodes #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The space is casually ignored by customers. It doesn't really matter, and won't cause any delivery / billing issues.
Other option is formatting the postcode input to contain the space. (The second part after the potential whitespace is always [0-9]{1}[a-zA-Z]{2})
|
Just to clarify: this will cause most of UK checkouts to stall. I'm working for a company that does address lookup for the UK, and we are rolling out our module for M2. (we are pretty popular for M1) This issue doesn't really affect us (we use a separate field anyhow & we return the postcode by the official Royal Mail format) however statistically it's not usual to place the space in the postcode. It's something that people tend to skip. However, the lack of proper validation error can make this an annoying experience for customers who just want to checkout. |
|
Looks good to me, internal ticket MAGETWO-41209 is created for processing this pull request. Thanks for the contribution! |
joanhe
added
the
Issue: Ready for Work
magento-team
pushed a commit
that referenced
this pull request
Sep 19, 2017
…recated-Tags [honey] MAGETWO-70580: Magento 2.2.0 Publication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space is casually ignored by customers. It doesn't really matter, and won't cause any delivery / billing issues.
Other option is formatting the postcode input to contain the space. (The second part after the potential whitespace is always [0-9]{1}[a-zA-Z]{2}, so it's 100% safe to insert the whitespace before this part, if it's missing.)
Or as a final option, make the validation error clear. (you missed the whitespace)
This change makes the whitespace optional.