[2.2-develop] Update Gallery Template to handle boolean config Variables #15020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes implemented in resolution to #12285, boolean configuration variables are now booleans, instead of the strings "true" and "false". Previous to this fix, values that were true were being output as var : 1 and values that were false were being output as var : This output for the false value is invalid.
|
Hi, @gwharton, I took your PR into processing, thank you for collaboration. |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 9, 2018
…y Template to handle boolean config Variables #15022
magento-engcom-team
added a commit
that referenced
this pull request
May 9, 2018
Accepted Public Pull Requests: - #15051: [Forwardport] Add statement to 'beforeSave' method to allow app:config:import (by @rogyar) - #15034: [Forwardport] fix: set message-success in setup if we already have the latest version (by @DanielRuf) - #15022: [2.3-develop] [ForwardPort] Port of #15020 Update Gallery Template to handle boolean config Variables (by @gwharton) - #15021: [2.3-develop] [ForwardPort] Port of #12285 The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery (by @gwharton) - #15081: [Forwardport] use "Module_Name::template/path" format instead of using template/path i� (by @adrian-martinez-interactiv4) - #15078: [Forwardport] Removed extra close tag (by @adrian-martinez-interactiv4) - #15075: [Forwardport] Removed extra spaces from language file (by @adrian-martinez-interactiv4) - #15073: [Forwardport] Changed return type of addToCartPostParams to array (by @adrian-martinez-interactiv4) - #15069: [Forwardport] Code cleanup, add more visibility (by @adrian-martinez-interactiv4) - #15083: [Forwardport] Fixed typos in .less files (by @adrian-martinez-interactiv4) - #15050: [Forwardport] Duplicate Order Confirmation Emails for PayPal Express checkout (by @rogyar) Fixed GitHub Issues: - #12285: The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery (reported by @novakivskiy) has been fixed in #15022 by @gwharton in 2.3-develop branch Related commits: 1. 163d4cc - #15009: [2.2.4] Gallery theme variables being ignored (reported by @gwharton) has been fixed in #15022 by @gwharton in 2.3-develop branch Related commits: 1. 163d4cc - #12285: The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery (reported by @novakivskiy) has been fixed in #15021 by @gwharton in 2.3-develop branch Related commits: 1. 435b165 2. 4113f26 3. c0b9e8f 4. 05b1512 5. 2701a4f
This was referenced May 9, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 9, 2018
|
Hi @gwharton. Thank you for your contribution. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to changes implemented in the resolution to #12285, boolean configuration variables are now properly typed booleans, instead of the strings "true" and "false".
Without this fix applied, config vals that were true were being output in the gallery template javascript as : 1 and values that were false were being output as :
This causes javascript errors for any item that is set to false.
Fixed Issues (if relevant)
Contribution checklist