[2.3-develop][Forwardport] Transport variable can not be altered in email_invoice_set_template_vars_before Event #15039
Conversation
Add missing commits for \app\code\Magento\Sales\Model\Order\Email\Sender\OrderSender.php
|
Hi, @gwharton , I took your PR into processing, thank you for collaboration. |
| $this->eventManager->dispatch( | ||
| 'email_order_set_template_vars_before', | ||
| ['sender' => $this, 'transport' => $transport] | ||
| ['sender' => $this, 'transport' => $transportObject->getData(), 'transportObject' => $transportObject] |
There was a problem hiding this comment.
Hi, @gwharton, due to Magento backward-compatible guide we can't rename or remove event arguments or change their type.
Adding the new arguments is allowed. If it doesn't help, you can introduce new event argument with new name or type and deprecate the old argument by adding @deprecated annotation before dispatching the event
There was a problem hiding this comment.
This is what has been done. $transport = $transportObject->getData() therefore the original arguments have not changed type or name. We introduce a new argument $transportObject
… altered in email_invoice_set_template_vars_before Event #15039
|
Hi @gwharton. Thank you for your contribution. |
Fix missing commits from #10210 Transport variable can not be altered in email_invoice_set_template_vars_before Event
Description
Original commit in #10210 missed updates to the /app/code/Magento/Sales/Model/Order/Email/Sender/OrderSender.php file
Fixed Issues (if relevant)
Contribution checklist