-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port 2.3-develop] Don't recalculate tax for every price on category page #15200
[Port 2.3-develop] Don't recalculate tax for every price on category page #15200
Conversation
@miguelbalparda, can you also process the port to |
Hi, @joachim-havloujian, I took your PR into processing, thank you for collaboration. |
@@ -832,20 +832,20 @@ public function getInfoUrl($store = null) | |||
* If it necessary will be returned conversion type (minus or plus) | |||
* | |||
* @param null|int|string|Store $store | |||
* @return bool | |||
* @return int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the method still returns int and bool value because $this->displayCartPricesBoth()
returns bool.
Please add bool return type to doc block.
@VladimirZaets DocBlock is updated. |
… on category page #15200
Hi @JeroenVanLeusden. Thank you for your contribution. |
Port of #15089
Description
Unnecessary recalculation of large product list pricing causes huge slowdowns.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist