Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove extraneous cursor property #15305

Merged
merged 1 commit into from Jun 1, 2018
Merged

chore: remove extraneous cursor property #15305

merged 1 commit into from Jun 1, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

cursor is not usable with pointer-events: none. Also this would add the not-allowed cursor which does not make much sense imho.

Manual testing scenarios

  1. create a button with the disabled property
  2. hover and click it
  3. there is no not-allowed cursor

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@DanielRuf DanielRuf deleted the chore/remove-extraneous-cursor-property branch June 1, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants