Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #13480 - Unable to activate logs after switching from production mode to developer #15335

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Fixed issue #13480 - Unable to activate logs after switching from production mode to developer #15335

merged 2 commits into from
Aug 8, 2018

Conversation

jayankaghosh
Copy link
Contributor

Description

Set the ENV value of dev/debug/debug_logging to null when deployment mode is "developer"

Fixed Issues (if relevant)

  1. Unable to activate logs after switching from production mode to developer  #13480: Unable to activate logs after switching from production mode to developer

Manual testing scenarios

  1. Set deployment version to "production"
  2. Clean the cache (if necessary)
  3. Set deployment version to "developer"
  4. Check the "Log To File" field under Stores > Configuration > Advanced > Developer > Debug
  5. "Log To File" field should be enabled

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@miguelbalparda miguelbalparda self-assigned this May 21, 2018
miguelbalparda
miguelbalparda reviewed Jun 8, 2018
View reviewed changes
app/code/Magento/Deploy/etc/di.xml
@@ -78,6 +78,9 @@
<item name="production" xsi:type="array">
<item name="dev/debug/debug_logging" xsi:type="string">0</item>
</item>
<item name="developer" xsi:type="array">
<item name="dev/debug/debug_logging" xsi:type="null" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this type=null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of dev/debug/debug_logging node in the app/etc/env.php would be set to null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I didn't find a way to remove the node from di.xml, hence setting it to null is the only way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelbalparda Any updates on this?

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2673 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Aug 8, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit c6aabf8 into magento:2.2-develop Aug 8, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2018
ENGCOM-2673: Fixed issue #13480 - Unable to activate logs after switc…
a2785b3 
…hing from production mode to developer #15335
@magento-engcom-team
Copy link
Contributor

Hi @jayankaghosh. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mage2pratik mage2pratik mentioned this pull request Aug 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda left review comments

@sidolov sidolov sidolov approved these changes

Assignees

@miguelbalparda miguelbalparda

@sidolov sidolov

Labels
Component: Deploy Event: dmcdindia Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@jayankaghosh @magento-cicd2 @magento-engcom-team @miguelbalparda @sidolov @vijay-wagento