Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Knockout non-unique elements id in console error #15349

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Resolve Knockout non-unique elements id in console error #15349

merged 2 commits into from
Jun 2, 2018

Conversation

neeta-wagento
Copy link
Contributor

When enabling more than one payment methods from admin, It is giving an error in the console "Found elements with non-unique id billing-address-form "

Description

Fixed Issues (if relevant)

  1. Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" #15348:
  2. Issue titleMultiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id"

Manual testing scenarios

  1. Login to Admin Panel > Sales> Payment Methods
  2. Enable more than one of Magento payment methods for checkout
  3. Add a product to the cart, press F12 to check the console log in the browser

Expected Result

It should not show any error in the console

Actual result

screenshot from 2018-05-19 14-10-36

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this May 21, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 22, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 22, 2018
@neeta-wagento
Copy link
Contributor Author

Hello @miguelbalparda ,
Could you please let me know why it is from Merging In Progress to TODO in Community Pull Requests? as its label is "accept".

@VladimirZaets
Copy link
Contributor

Hi @neeta-wagento, I working on your PR. Our internal tests are failed. Some functionality uses this ID, I will fix it and after that we will move PR to Merging In Progress again. Thanks

@magento-engcom-team
Copy link
Contributor

Hi @neeta-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: dmcdindia Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants