Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim username on customer account login page #15365

Merged
merged 3 commits into from
Jun 5, 2018

Conversation

dankhrapiyush
Copy link
Contributor

Trim email address on customer account login page generally when copy and paste.

Description

Trim email address by remove leading or trailing space on the customer account login page email field.

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer account login page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " johndoe@domain.com " and paste in the Email field. It will automatically remove leading or trailing space.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
All committers have signed the CLA.

@dankhrapiyush
Copy link
Contributor Author

Thanks @vgelani

@VladimirZaets
Copy link
Contributor

Hi @dankhrapiyush, thank you for collaboration.
Can you please remove trimUsername declaration from requirejs-config.js and use path Magento_Customer/js/trim-username obviously inside .phtml.

@dankhrapiyush
Copy link
Contributor Author

@VladimirZaets Removed trimUsername declaration from requirejs-config.js and used path Magento_Customer/js/trim-username inside .phtml.

I'm not getting why the Travis CI build could not complete.

Thank you.

@VladimirZaets
Copy link
Contributor

@dankhrapiyush thanks. Currently, we have some problem with Travis. It isn't PR problem.

@dankhrapiyush
Copy link
Contributor Author

@VladimirZaets Okay, Thank you.

@magento-engcom-team magento-engcom-team merged commit c81d9a6 into magento:2.2-develop Jun 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dankhrapiyush. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants