-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 15467 where a configuration sku gets deleted but is still saved… #15468
Issue 15467 where a configuration sku gets deleted but is still saved… #15468
Conversation
… in a customer cart
@jonshipman thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @jonshipman thank you for this PR. There are some static test failures. Would you be able to update your PR to fix these?
|
Thanks for the update @jonshipman code styling looks good now. I will start processing this pull request. |
Hi @jonshipman. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Nothing to forwardport due to MAGETWO-75086, in scope of which was deleted Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable::getProductForThumbnail() dd602f7 and MAGETWO-8709 where was deleted Magento/ConfigurableProduct/CustomerData/ConfigurableItem 74dff42 |
#15467
Reproduce: Add a configuration product to your cart logged in as a customer. Log out.
Have an admin delete the product SKU from the configuration product.
Customer: login to your cart from checkout (add something to your cart logged out and login with the modal window).
You will get an error about getThumbnail() on a null object. This commit fixes the issue in two files.