Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 15467 where a configuration sku gets deleted but is still saved… #15468

Merged
merged 2 commits into from
Jun 1, 2018

Conversation

jonshipman
Copy link

#15467

Reproduce: Add a configuration product to your cart logged in as a customer. Log out.
Have an admin delete the product SKU from the configuration product.
Customer: login to your cart from checkout (add something to your cart logged out and login with the modal window).

You will get an error about getThumbnail() on a null object. This commit fixes the issue in two files.

@magento-engcom-team
Copy link
Contributor

@jonshipman thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dmanners
Copy link
Contributor

Hi @jonshipman thank you for this PR.

There are some static test failures. Would you be able to update your PR to fix these?

There was 1 failure:
1) Magento\Test\Php\LiveCodeTest::testCodeStyle
PHP Code Sniffer detected 1 violation(s): 
FILE: ...code/Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 71 | ERROR | Line exceeds maximum limit of 120 characters; contains 145
    |       | characters
--------------------------------------------------------------------------------
FILE: ...to2/app/code/Magento/ConfigurableProduct/CustomerData/ConfigurableItem.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 66 | ERROR | Line exceeds maximum limit of 120 characters; contains 149
    |       | characters
--------------------------------------------------------------------------------

@dmanners
Copy link
Contributor

Thanks for the update @jonshipman code styling looks good now. I will start processing this pull request.

@magento-engcom-team
Copy link
Contributor

Hi @jonshipman. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@nmalevanec
Copy link
Contributor

Nothing to forwardport due to MAGETWO-75086, in scope of which was deleted Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable::getProductForThumbnail() dd602f7 and MAGETWO-8709 where was deleted Magento/ConfigurableProduct/CustomerData/ConfigurableItem 74dff42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants