Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14294 - Fixes 'back' functionality after switching a store view. #15503

Conversation

Mobecls
Copy link
Contributor

@Mobecls Mobecls commented May 24, 2018

Description

Adds getStoreUrl() method to app/code/Magento/Store/Block/Switcher.php
Modifies switcher-option's links in Magento/Store/view/frontend/templates/switch/stores.phtml and Magento/Store/view/frontend/templates/switch/languages.phtml templates

Fixed Issues (if relevant)

  1. Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality. #14294: Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Mobecls added 2 commits May 24, 2018 19:52
Adds getStoreUrl() method to app/code/Magento/Store/Block/Switcher.php
Modifies switcher-option's links in Magento/Store/view/frontend/templates/switch/stores.phtml and languages.phtml templates
Fixes 'Potentially XSS vulnerability. Please verify that output is escaped'.
@Mobecls Mobecls closed this May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant