Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in catalog component blocks [2.3-develop] #15558

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Fixes in catalog component blocks [2.3-develop] #15558

merged 1 commit into from
Jun 6, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented May 28, 2018

Description

This PR fixes a few PHPDocs and annotations typos along with wrong return type suggestions.

It also solves an issue with the method Magento\Backend\Block\Widget\Grid\Extended::addColumn() invoking with 3 parameters when only 2 are required. See line 105

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio
Copy link
Member

osrecio commented May 29, 2018

Hi @mhauri , Thanks for your contribution.

Can you squash your commit ?

Thanks!

@osrecio osrecio self-assigned this May 29, 2018
@mhauri
Copy link
Author

mhauri commented May 29, 2018

@osrecio not sure how to to that in the aftermath? Is this an Issue?

@osrecio
Copy link
Member

osrecio commented May 29, 2018

Hi @mhauri I sent you a message in engcom slack to explain you how to make a squash.
Is good practice to have only one commit by PR.
Thanks!

@mhauri
Copy link
Author

mhauri commented May 30, 2018

Thank you @osrecio for the help with rebasing. Hope it's fine now.

@osrecio
Copy link
Member

osrecio commented May 30, 2018

Now is fine! I will process your PR asap 😄

@mhauri
Copy link
Author

mhauri commented Jun 1, 2018

Hi @osrecio anything else required to process this PR?

@osrecio
Copy link
Member

osrecio commented Jun 4, 2018

No @mhauri , I'm checking internal processes and tests to verify that all is correct. Thanks

@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants