-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in catalog component blocks [2.3-develop] #15558
Fixes in catalog component blocks [2.3-develop] #15558
Conversation
Hi @mhauri , Thanks for your contribution. Can you squash your commit ? Thanks! |
@osrecio not sure how to to that in the aftermath? Is this an Issue? |
Hi @mhauri I sent you a message in engcom slack to explain you how to make a squash. |
Thank you @osrecio for the help with rebasing. Hope it's fine now. |
Now is fine! I will process your PR asap 😄 |
Hi @osrecio anything else required to process this PR? |
No @mhauri , I'm checking internal processes and tests to verify that all is correct. Thanks |
Hi @mhauri. Thank you for your contribution. |
Description
This PR fixes a few PHPDocs and annotations typos along with wrong return type suggestions.
It also solves an issue with the method
Magento\Backend\Block\Widget\Grid\Extended::addColumn()
invoking with 3 parameters when only 2 are required. See line 105Contribution checklist