Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] [improvement] Swatches LESS rewrite #15624

Merged
merged 3 commits into from
Jul 5, 2018
Merged

[2.3] [improvement] Swatches LESS rewrite #15624

merged 3 commits into from
Jul 5, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented May 31, 2018

Rewrote LESS code to suit better with Magento LESS mixins and variables.

Fixed Issues (if relevant)

File was missing LESS variables

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Karlasa
swatches LESS rewrite
46d4116 
Rewrote LESS code to suit better with Magneto Blank theme
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 31, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
Karlasa added 2 commits June 7, 2018 16:40
@Karlasa
replaced loading gif
c52f795 
Replaced loading gif with Theme loader gif.
@Karlasa
Deleting loader gif
b4098fe 
Replaced with Theme loader
@VladimirZaets
Copy link
Contributor

Hi, @Karlasa, I took your PR into processing, thank you for collaboration.

@magento-engcom-team magento-engcom-team merged commit b4098fe into magento:2.3-develop Jul 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2018
@VladimirZaets
ENGCOM-1816: [2.3] [improvement] Swatches LESS rewrite #15624
6bb673f
magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2018
ENGCOM-1816: [2.3] [improvement] Swatches LESS rewrite #15624
8949985
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@Karlasa Karlasa deleted the swatches-less branch August 17, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Area: Frontend Award: complex improvement Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Karlasa @magento-cicd2 @VladimirZaets @magento-engcom-team