Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Fixes in config module #15649

Merged
merged 1 commit into from
Jun 6, 2018
Merged

[Forwardport] Fixes in config module #15649

merged 1 commit into from
Jun 6, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented Jun 1, 2018 •
edited
Loading

Original Pull Request

#15511

Description

This PR fixes two issues in the Magento/Config Module:

  1. The method Magento/Config/Test/Unit/Block/System/Config/Form/Field/ImageTest.php::testGetElementHtmlWithValue() references to a invalid Backend Model on line 75

  2. The anonymous function has an unused use $data in Magento/Config/Model/Config/Importer.php on line 127

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 1, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mhauri mhauri changed the base branch from 2.2-develop to 2.3-develop June 1, 2018 06:38
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 2, 2018
@magento-engcom-team magento-engcom-team merged commit 9e4cc7b into magento:2.3-develop Jun 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 6, 2018
ENGCOM-1782: [Forwardport] Fixes in config module #15649
7e1b294
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Component: Config Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mhauri @magento-cicd2 @magento-engcom-team @sidolov @gelanivishal