Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to string $option->getValue, in order to be compared with oth… #15720

Conversation

zamboten
Copy link
Contributor

@zamboten zamboten commented Jun 3, 2018

#mm18it
…er saved options in previous cart items

Description

To decide whether a product with the same options is already present in the cart, magento makes a comparison with the string that represents the buyrequest in json format with those saved in the database. When a product is added by the Rest API the option code attribute encoded in the json is a number, whereas from the frontend context it is a string. In this case, this bufix forces the option attribute value in string, creating arrays that will later be converted into json

Fixed Issues (if relevant)

  1. Configurable product addtocart with restAPI not working as expected #15028:Configurable product addtocart with restAPI not working as expected2. ...

Manual testing scenarios

Same test performed by issue writer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 3, 2018

CLA assistant check
All committers have signed the CLA.

@phoenix128
Copy link
Contributor

Hello @zamboten ,
plase accept the CLA so we can merge your PR.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2671 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@zamboten thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 03298b3 into magento:2.2-develop Aug 8, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @zamboten. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants