-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolved : Styling <select> by changing less variables in Luma theme… #15734
[Resolved : Styling <select> by changing less variables in Luma theme… #15734
Conversation
… doesn't work as expected magento#15608]
background-size: 30px 60px; | ||
border: 1px solid @border-color__base; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the @select__border and other variables defined / used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's define in lib/web/css/source/lib/variables/_forms.less
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I do not (directly) see its usage anywhere. I'm speaking about the newly added variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't created/added any new variables. all variables are in lib/web/css/source/lib/variables/_forms.less
I have just moved _forms.less
CSS in _theme.less
so we can change select CSS without using !important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, found them =) @{@{_type}__background}
and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just want to check the inheritance and usage of the variables to understand the issue better and detect similar issues.
Hi @hitesh-wagento. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Have "select" elements with the styles you set in _theme.less
Description
Fixed Issues (if relevant)
select
by changing less variables in Luma theme doesn't work as expectedManual testing scenarios
@select__background: rgba(255, 255, 255, 0.15);
@select__border: 2px dashed blue;
@select__height: 50px;
@select__padding: 15px 40px 15px 15px;
@select__background-clip: border-box;
Contribution checklist