Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix method name (typo) #15745

Conversation

vijay-wagento
Copy link

Original Pull Request

#15514

Description

This PR deprecates a current method with a typo and introduces the new method with correct spelling

Fixed Issues (if relevant)

none

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@@ -5,7 +5,7 @@
*/

/**
* Multishipping checkout base abstract block
* Mustishipping checkout base abstract block
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mustishipping?
Cc: @avoelkl @dmanners

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @orlangur thanks for this. I have already reached out to @avoelkl with regards to this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not back/forwardort this PR as i accendentially added (and reverted later again) a commit that was supposed to be in another PR.
The typos were fixed in a seperate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijay-wagento @avoelkl @dmanners
I think we should fix typos in current PR. We haven't the reason to do it in separate PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets I will do it in same PR

Fix typo in doc block.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 4, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @vijay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants