Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing #15748

Conversation

vijay-wagento
Copy link

Original Pull Request

#15409

Description

catalogAddToCart widget initialize its functions for all suitable elements:

This commit fixes this by additional catalog-addtocart-initialized flag.

Manual testing scenarios

  1. Navigate to the category with products.

  2. Open developer console and execute the following script:

    jQuery('footer').append('<script type="text/x-magento-init">{"[data-role=tocart-form], .form.map.checkout": {"catalogAddToCart": {}}}</script>');
    jQuery('footer').trigger('contentUpdated');

    This scenario is a simplified case that may happen when some third-party widget loads ajax products listing on the page using standard listing template.

  3. Open "Network" tab and press "Add to cart" on some product.

  4. Two requests will be sent instead of one.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Catalog labels Jun 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
@magento-engcom-team magento-engcom-team merged commit 868c077 into magento:2.3-develop Jun 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vijay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

magento-engcom-team pushed a commit that referenced this pull request Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Catalog Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants