Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] fix: support multiple minisearch widget instances #15809

Merged
merged 1 commit into from Jun 6, 2018
Merged

Conversation

DanielRuf
Copy link
Contributor

Original Pull Request

#15485

Description

When cloning the minisearch widget and changing the ID's and selectors they still trigger all instances as the label searchLabel is globally searched instead of in the form.

Manual testing scenarios

  1. clone module-search/view/frontend/templates/form.mini.phtml
  2. add custom block with the cloned and changed minisearch widget (after changing ID's and selectors in it)
  3. click on search icon on mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@DanielRuf DanielRuf deleted the 2.3-develop-PR-port-15485 branch June 6, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants