Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix for issue 911 found on MSI project - Cannot read property source_… #14 #15840

Merged
merged 1 commit into from
Jun 6, 2018
Merged

[Backport] Fix for issue 911 found on MSI project - Cannot read property source_… #14 #15840

merged 1 commit into from
Jun 6, 2018

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#14805
…code of undefined

Dynamic data rows were failing due to a read after delete condition
Rows were removed just before the information update. An undefined javascript error was triggered.

This issue has ben found in MSI, but it comes from core implementation.

Fixed Issues (if relevant)

  1. Cannot read property source_code of undefined inventory#911: Cannot read property source_code of undefined

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…code of undefined Dynamic data rows were failing due to a read after delete condition Rows were removed just before the information update. An undefined javascript error was triggered.
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Ui Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants